Skip to content

Add new vignette for tips and tricks - #311

Merged
agila5 merged 1 commit into
masterfrom
tips-tricks
Jul 14, 2025
Merged

Add new vignette for tips and tricks#311
agila5 merged 1 commit into
masterfrom
tips-tricks

Conversation

@agila5

@agila5 agila5 commented Jul 14, 2025

Copy link
Copy Markdown
Contributor

I believe this new vignette might be a nice place to collect all examples and use cases which do not deserve an ad-hoc page in the docs but are still worth of presentation.

See also #249.

@agila5
agila5 requested a review from Copilot July 14, 2025 10:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new vignette that collects various tips and tricks for using the osmextract package.

  • Introduces vignettes/tips-and-tricks.Rmd with setup and cleanup code chunks
  • Provides an example of selecting OSM objects by their IDs
  • Manages download directory and restores user settings after execution
Comments suppressed due to low confidence (2)

vignettes/tips-and-tricks.Rmd:19

  • [nitpick] The variable name 'user_par' is ambiguous; consider renaming to 'original_pars' or 'user_parameters' for better clarity.
user_par = par(no.readonly = TRUE)

vignettes/tips-and-tricks.Rmd:22

  • [nitpick] The variable name 'old_dd' is unclear; consider renaming to 'original_download_dir' to improve readability.
old_dd = Sys.getenv("OSMEXT_DOWNLOAD_DIRECTORY", tempdir())

Comment thread vignettes/tips-and-tricks.Rmd
Comment thread vignettes/tips-and-tricks.Rmd
Comment thread vignettes/tips-and-tricks.Rmd
Comment thread vignettes/tips-and-tricks.Rmd
@agila5
agila5 requested a review from Robinlovelace July 14, 2025 10:28
@agila5
agila5 merged commit fadaa92 into master Jul 14, 2025
3 checks passed
@agila5
agila5 deleted the tips-tricks branch July 14, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants